Skip to content

Conversation

denisx
Copy link

@denisx denisx commented Dec 5, 2024

What issue does this pull request resolve?

To emulate esm build, you need couple thing at package.json: module and sideeffects

What changes did you make?

Bundlers will cut unused code better then now. Goog for named imports.

@denisx
Copy link
Author

denisx commented Dec 5, 2024

@eventualbuddha @Delapouite hello here! )

@jasoniangreen
Copy link
Collaborator

Thanks for your contribution @denisx. This change seems to be correct to me, just give me some time to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants