Skip to content

Feat/dohrmy 139 dom#45

Open
pareddyakamai wants to merge 5 commits into
integrationfrom
feat/DOHRMY-139-DOM
Open

Feat/dohrmy 139 dom#45
pareddyakamai wants to merge 5 commits into
integrationfrom
feat/DOHRMY-139-DOM

Conversation

@pareddyakamai

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread delivery/main.tf
}
# akamai_property_domainownership_late_validation resource is used to verify the validation state of your hostnames and activate your property on a network.
resource "akamai_property_domainownership_late_validation" "this" {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a condition so that late validation is an option and not mandatory. A user can perform a pre-validation which wouldn't require this resource. Check out this example https://github.com/akamai/terraform-examples/blob/main/products/domain-ownership/late-validation/main.tf

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pareddyakamai I was referring more like a condition that would optionally enable the DOM post-validation flow. The reason is post-validation should also take into account the DNS validations, otherwise the activations will fail. Plus @rlopezso has a good point in which we could perform a check that the domains are validated prior to running the DOM module. What if we remove the post-validation flow for now and keep the pre-validation to avoid more delays.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pareddyakamai we've decided to remove the late validation flow for now because of the DNS dependecies to validate the domains.

Comment thread dom/versions.tf
Comment thread dom/main.tf
Comment thread dom/outputs.tf
Comment thread delivery/main.tf

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jaime that this should be eligible and not mandated. But would it make more sense to add this to the DOM module? And through the deploy script, validate whether the domains are validated or not, and then call the dom module to perform the late validation?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pareddyakamai this is related to removing the post validation flow for now.

@rlopezso rlopezso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why there are so many "dummy" changes to the Readme files?

Comment thread aap-asm/activate-security/README.md Outdated
Comment thread delivery/main.tf
}
# akamai_property_domainownership_late_validation resource is used to verify the validation state of your hostnames and activate your property on a network.
resource "akamai_property_domainownership_late_validation" "this" {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pareddyakamai I was referring more like a condition that would optionally enable the DOM post-validation flow. The reason is post-validation should also take into account the DNS validations, otherwise the activations will fail. Plus @rlopezso has a good point in which we could perform a check that the domains are validated prior to running the DOM module. What if we remove the post-validation flow for now and keep the pre-validation to avoid more delays.

Comment thread dom/main.tf
@@ -0,0 +1,44 @@

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty line for the terraform-docs to add the documentation in this main.tf to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants