Feat/dohrmy 139 dom#45
Conversation
| } | ||
| # akamai_property_domainownership_late_validation resource is used to verify the validation state of your hostnames and activate your property on a network. | ||
| resource "akamai_property_domainownership_late_validation" "this" { | ||
|
|
There was a problem hiding this comment.
We should have a condition so that late validation is an option and not mandatory. A user can perform a pre-validation which wouldn't require this resource. Check out this example https://github.com/akamai/terraform-examples/blob/main/products/domain-ownership/late-validation/main.tf
There was a problem hiding this comment.
@pareddyakamai I was referring more like a condition that would optionally enable the DOM post-validation flow. The reason is post-validation should also take into account the DNS validations, otherwise the activations will fail. Plus @rlopezso has a good point in which we could perform a check that the domains are validated prior to running the DOM module. What if we remove the post-validation flow for now and keep the pre-validation to avoid more delays.
There was a problem hiding this comment.
@pareddyakamai we've decided to remove the late validation flow for now because of the DNS dependecies to validate the domains.
There was a problem hiding this comment.
I agree with Jaime that this should be eligible and not mandated. But would it make more sense to add this to the DOM module? And through the deploy script, validate whether the domains are validated or not, and then call the dom module to perform the late validation?
There was a problem hiding this comment.
@pareddyakamai this is related to removing the post validation flow for now.
rlopezso
left a comment
There was a problem hiding this comment.
Wonder why there are so many "dummy" changes to the Readme files?
…9-DOM fixing the merge issue
0839355 to
412904b
Compare
| } | ||
| # akamai_property_domainownership_late_validation resource is used to verify the validation state of your hostnames and activate your property on a network. | ||
| resource "akamai_property_domainownership_late_validation" "this" { | ||
|
|
There was a problem hiding this comment.
@pareddyakamai I was referring more like a condition that would optionally enable the DOM post-validation flow. The reason is post-validation should also take into account the DNS validations, otherwise the activations will fail. Plus @rlopezso has a good point in which we could perform a check that the domains are validated prior to running the DOM module. What if we remove the post-validation flow for now and keep the pre-validation to avoid more delays.
| @@ -0,0 +1,44 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove this empty line for the terraform-docs to add the documentation in this main.tf to the README.
No description provided.