Fix/dohrmy 131 & 148 templates delivery#59
Open
rlopezso wants to merge 4 commits into
Open
Conversation
* Added validation in `PropertyManager.psm1` to verify that mPulse is available in the contract when the corresponding Terraform variable is enabled. * Removed the unused `dummy_test` variable. * Added the `forward_host_header` variable to support parameterization of the Forward Host Header setting within the module. * Updated the `additional_origins` variable to align with the Forward Host Header enhancements. * Added the `default_cpcode` variable to allow selection of the default CP Code. * Corrected typos in variable descriptions. * Updated `ip_behavior` validation to support only `IPV4` and `IPV6_COMPLIANCE`. Terraform variable templates (`.tfvars`) were updated to reflect the above changes. Additionally, several variable validation rules were refactored. Since newer Terraform versions no longer allow cross-variable references within validation conditions, equivalent pre-validation checks were implemented in `main.tf`.
- adjust deploy script and update provider/variable configurations - Run drift only when state file existed before initializing terraform - Move check blocks to variables file - Set akamai provider version to "10.1" - Add default_cpcode to tfvar sample files
Contributor
Deployment Test Results17 tests 17 ✅ 0s ⏱️ Results for commit c443275. ♻️ This comment has been updated with latest results. |
jaescalo
requested changes
Jul 9, 2026
| module "property" { | ||
| source = "git::ssh://git@github.com/akamai/terraform-templates-modules.git//delivery?ref=v1.3.3" | ||
|
|
||
| source = "git::ssh://git@github.com/akamai/terraform-templates-modules.git//delivery?ref=integration" |
Collaborator
There was a problem hiding this comment.
@rlopezso we must use tag ref=v1.4.0 instead (https://github.com/akamai/terraform-templates-modules/releases/tag/v1.4.0)
Collaborator
There was a problem hiding this comment.
@rlopezso you should be able to set the tag to v1.5.0 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to support DOHRMY-131 and DOHRMY-148
Changes Included
TerraformRunner.psm1
PropertyManager.psm1
enabled_mpulseis set totrue, the workflow now verifies that mPulse is included in the contract before proceeding.Sample tfvars Updates
Updated the
new_propertysample tfvars files for dev, qa, and prod environments to:forward_host_headervariable.default_cpcodevariable.additional_originsvariable schema.new_property/main.tf
var.dummy_test.var.forward_host_header.var.default_cpcode.new_property/variables.tf
Added definitions and validation for:
forward_host_headerdefault_cpcodeUpdated the
additional_originsvariable schema.Refactored several cross-variable validations into Terraform
checkblocks, as recent Terraform versions no longer reliably support validations that reference other variables within a variable validation block.new_property/versions.tf
Updated the Akamai provider version constraint to support version 10.1.