Skip to content

Commit

Permalink
fix: patch to add credentials null to fix live deployments
Browse files Browse the repository at this point in the history
  • Loading branch information
baktun14 committed May 2, 2024
1 parent 80c31da commit a9e77ef
Show file tree
Hide file tree
Showing 11 changed files with 168 additions and 152 deletions.
3 changes: 2 additions & 1 deletion src/sdl/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,8 @@ export class SDL {
resources: this.serviceResourcesBeta3(id, profile as v3ProfileCompute, service, asString),
count: deployment[placement].count,
expose: this.v3ManifestExpose(service),
params: this.v3ManifestServiceParams(service.params)
params: this.v3ManifestServiceParams(service.params),
credentials: null
};
}

Expand Down
9 changes: 9 additions & 0 deletions src/sdl/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export type v3ManifestService = {
count: number;
expose: v3ServiceExpose[];
params: v3ManifestServiceParams | null;
credentials: v2ServiceImageCredentials | null;
};

export type v2ServiceExposeHttpOptions = {
Expand Down Expand Up @@ -149,6 +150,13 @@ export type v2ServiceParams = {
storage?: Record<string, v2ServiceStorageParams>;
};

export type v2ServiceImageCredentials = {
host: string;
email: string;
username: string;
password: string;
};

export type v2Service = {
image: string;
command: string[] | null;
Expand All @@ -157,6 +165,7 @@ export type v2Service = {
expose: v2Expose[];
dependencies?: v2Dependency[];
params?: v2ServiceParams;
credentials?: v2ServiceImageCredentials;
};

export type v2ServiceDeployment = {
Expand Down
60 changes: 30 additions & 30 deletions tap-snapshots/tests/test_sdl_gpu.ts.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,37 @@
'use strict'
exports[`tests/test_sdl_gpu.ts TAP SDL: GPU Version > Manifest version matches expected result 1`] = `
Uint8Array [
137,
34,
44,
185,
67,
178,
219,
111,
250,
3,
51,
238,
33,
176,
251,
28,
239,
51,
143,
144,
183,
207,
220,
163,
146,
195,
180,
146,
237,
162,
249,
106,
141,
116,
162,
79,
254,
241,
232,
250,
77,
2,
152,
132,
190,
248,
131,
169,
120,
12,
252,
95,
187,
83,
36,
113,
57,
229,
108,
29,
181,
208,
]
`
60 changes: 30 additions & 30 deletions tap-snapshots/tests/test_sdl_gpu_ram.ts.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,37 @@
'use strict'
exports[`tests/test_sdl_gpu_ram.ts TAP SDL: GPU Version with ram > Manifest version matches expected result 1`] = `
Uint8Array [
50,
21,
172,
84,
232,
121,
147,
231,
161,
228,
174,
230,
225,
220,
123,
116,
14,
51,
6,
102,
163,
189,
49,
102,
39,
107,
0,
213,
171,
201,
136,
51,
16,
16,
241,
252,
98,
21,
229,
89,
194,
116,
190,
12,
100,
70,
181,
1,
203,
72,
148,
37,
244,
151,
7,
45,
73,
63,
222,
235,
167,
21,
]
`
57 changes: 29 additions & 28 deletions tap-snapshots/tests/test_sdl_gpu_vendor_only.ts.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Array [
"args": null,
"command": null,
"count": 2,
"credentials": null,
"env": null,
"expose": Array [
Object {
Expand Down Expand Up @@ -113,37 +114,37 @@ Array [

exports[`tests/test_sdl_gpu_vendor_only.ts TAP SDL: GPU Version > Manifest version matches expected result 1`] = `
Uint8Array [
5,
115,
192,
79,
131,
204,
202,
111,
169,
0,
170,
30,
162,
78,
50,
203,
181,
13,
28,
54,
223,
45,
8,
100,
93,
19,
118,
61,
128,
25,
109,
38,
193,
233,
21,
99,
255,
92,
148,
156,
163,
120,
168,
62,
173,
73,
11,
208,
225,
180,
242,
36,
7,
166,
206,
142,
2,
92,
72,
112,
]
`
60 changes: 30 additions & 30 deletions tap-snapshots/tests/test_sdl_wordpress.ts.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -220,37 +220,37 @@ Array [

exports[`tests/test_sdl_wordpress.ts TAP SDL: Wordpress Version > Manifest version matches expected result 1`] = `
Uint8Array [
219,
108,
51,
117,
198,
203,
254,
23,
231,
87,
195,
36,
147,
215,
27,
25,
65,
116,
86,
242,
189,
131,
165,
98,
41,
59,
109,
246,
224,
47,
134,
151,
175,
212,
63,
194,
233,
63,
64,
39,
166,
185,
123,
9,
234,
39,
45,
57,
28,
107,
76,
26,
88,
129,
224,
141,
48,
178,
188,
237,
211,
251,
]
`
60 changes: 30 additions & 30 deletions tests/__snapshots__/sdl_gpu_ram_interface.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,37 @@

exports[`test GPU with interface SDL: GPU Version with ram & interface (snapshot): Manifest version matches expected result 1`] = `
Uint8Array [
125,
11,
116,
78,
176,
162,
8,
51,
138,
226,
67,
148,
236,
175,
65,
207,
31,
215,
174,
241,
237,
29,
110,
140,
117,
18,
69,
120,
159,
139,
72,
2,
24,
7,
93,
95,
222,
143,
33,
226,
12,
115,
209,
33,
103,
233,
49,
164,
163,
133,
82,
130,
5,
142,
99,
128,
162,
159,
210,
200,
56,
178,
]
`;
3 changes: 2 additions & 1 deletion tests/fixtures/gpu_basic.manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@
"endpointSequenceNumber": 0
}
],
"params": null
"params": null,
"credentials": null
}
]
}
Expand Down
Loading

0 comments on commit a9e77ef

Please sign in to comment.