-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logger #102
Open
jaseemuddinn
wants to merge
1
commit into
akash-network:main
Choose a base branch
from
jaseemuddinn:implement-logger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement logger #102
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,11 @@ | |
<button id="getCerts">Get Certs</button> | ||
|
||
<script type="text/javascript"> | ||
console.log(akjs); | ||
import pino from 'pino'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does that actually work? |
||
|
||
const logger = pino(); | ||
|
||
logger.info(akjs); | ||
|
||
const fn = async () => { | ||
const certs = await akjs.certificate.createCertificate("akash12345"); | ||
|
@@ -27,7 +31,7 @@ | |
document.querySelector("#privateKey").value = certs.privateKey; | ||
|
||
window.addEventListener("DOMContentLoaded", async (event) => { | ||
console.log("DOM fully loaded and parsed"); | ||
logger.info("DOM fully loaded and parsed"); | ||
chain = akjs.keplr.getChains().testnet; | ||
signer = await akjs.keplr.getSigner(chain); | ||
client = await akjs.keplr.get(chain, signer); | ||
|
@@ -45,7 +49,7 @@ | |
client | ||
); | ||
} catch (error) { | ||
console.log(`Akash Transport : ${error.message}`); | ||
logger.info(`Akash Transport : ${error.message}`); | ||
} | ||
}); | ||
|
||
|
@@ -58,7 +62,7 @@ | |
}) | ||
); | ||
|
||
console.log(certs); | ||
logger.info(certs); | ||
}); | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import tap from "tap"; | ||
import pino from "pino"; | ||
|
||
import { testSnap } from "./util"; | ||
|
||
|
@@ -11,6 +12,8 @@ import { | |
QueryDeploymentsResponse | ||
} from "@akashnetwork/akash-api/akash/deployment/v1beta3/query"; | ||
|
||
const logger = pino(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably not needed |
||
|
||
tap.test("Deployments: query deployment list with owner filter", async t => { | ||
t.plan(1); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you install pino? I don't see it in the package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe I forgot to add package.json while pushing the code.