-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): adds more CI validations, introduces semantic release (#74) #75
Conversation
b73ad0a
to
b0c356f
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
as discussed with @baktun14 we also would need to properly handle commit linting for squash merge. On the surface solution is to take PR title as a squash commit and lint it to allow merge |
@akash-network/cloudmos I suggest that we split checks into dedicated jobs:
Then protect merge in to main the same way it's done in https://github.com/akash-network/akash-api/settings/branch_protection_rules/34186868 This way those would run independently addressing a scenario like when you're pushing commits that wouldn't pass linting but would pass tests. However there's an issue with this anyway. There is no way to conditionally allow a certain type of merge (squash/rebase/merge). So to address any case a feature PR would need to have valid commit messages AND the title. This would require to come up with proper commit names as you go and might kill the purpose of squash merge. Let's try to work out what we'd like this to be |
Yea it would be a bit annoying to have to have valid commits AND title. Not the biggest deal, but I think since we've been doing squash merges from the beginning, it make sense to only apply the pr title contraint and suggest for the commits if you plan to do a normal merge. |
So one another way to do this may be to ONLY allow squash commits (not sure how would that work with just 1 in pr) and validate the title. And another one (a mild one) would be not to fail a check but to post a warning. I'd prob try going with the more strict one. |
Yea makes sense to me |
a17bd97
to
9a49a5b
Compare
ada3bb2
to
7d48a7f
Compare
Also: - Uses semantic release - Adds checks on before commit and in CI: eslint and commit lint
Feature: Enhance CI Validations and Introduce Semantic Release
This pull request introduces several enhancements to our Continuous Integration (CI) pipeline and implements Semantic Release for automated version management and changelog generation. These changes aim to bolster code quality and streamline our release process.
Key Changes
ESLint Integration
Commit Linting
Semantic Release
main
branch.Code Coverage Reporting
Benefits
Additional Notes
npm install
after pulling these changes.Associated Issues