fix: add required persistent attribute when using ram class storage #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redm4x
changed the title
Redm4x
force-pushed
the
bugfixes/fix-ram-storage-persistent-attribute
branch
from
c615ddf to
8c895ea
Compare
baktun14
approved these changes
Apr 23, 2024
ygrishajev
reviewed
Apr 23, 2024
src/sdl/index.ts
Outdated
| @@ -252,6 +252,20 @@ export class SDL { | |||
| ); | |||
| } | |||
|
|
|||
| serviceResourceStorageAttributes(attributes?: Record<string, any>) { | |||
There was a problem hiding this comment.
There is a type in ./types which is the same however would simplify things when we get to refactoring
Suggested change
| serviceResourceStorageAttributes(attributes?: Record<string, any>) { | |
| serviceResourceStorageAttributes(attributes?: v2StorageAttributes) { |
Redm4x
force-pushed
the
bugfixes/fix-ram-storage-persistent-attribute
branch
from
8c895ea to
6e96df3
Compare
ygrishajev
approved these changes
Apr 29, 2024
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using storage with class "ram", the persistent attribute must be set to false. This change make sure to add the persistent attribute if it is missing.
akash-network/console#147