fix: prevent duplicate persistent attribute when using ram storage

src/sdl/index.ts

@@ -40,11 +40,11 @@
 export const GPU_SUPPORTED_VENDORS = ["nvidia", "amd"];
 export const GPU_SUPPORTED_INTERFACES = ["pcie", "sxm"];
 
 function isArray<T>(obj: any): obj is Array<T> {
   return Array.isArray(obj);
 }
 
 function isString(str: any): str is string {
   return typeof str === "string";
 }
 
@@ -244,7 +244,7 @@
     );
   }
 
   serviceResourceAttributes(attributes?: Record<string, any>) {
     return (
       attributes &&
       Object.keys(attributes)
@@ -258,7 +258,7 @@
 
     const pairs = Object.keys(attributes).map(key => ({ key, value: attributes[key].toString() }));
 
-    if (attributes.class === "ram" && !attributes.persistent) {
+    if (attributes.class === "ram" && !("persistent" in attributes)) {
       pairs.push({ key: "persistent", value: "false" });
     }
 
@@ -689,7 +689,7 @@
 
     const units = {
       endpoints: null
     } as any;
 
     if (resource.cpu) {
       units.cpu = this.resourceUnitCpu(resource, asString);
@@ -790,7 +790,7 @@
             resource: res,
             price: price,
             count: svcdepl.count
           } as any);
 
           group.boundComputes[placementName][svcdepl.profile] = group.dgroup.resources.length - 1;
         } else {
@@ -798,7 +798,7 @@
           // resources.id = group.dgroup.resources[location].id;
 
           group.dgroup.resources[location].count += svcdepl.count;
           group.dgroup.resources[location].endpoints += endpoints as any;
           group.dgroup.resources[location].endpoints.sort();
         }
       }
@@ -813,7 +813,7 @@
     const yamlJson = this.data;
     const ipEndpointNames = this.computeEndpointSequenceNumbers(yamlJson);
 
     const groups = {} as any;
 
     Object.keys(yamlJson.services).forEach(svcName => {
       const svc = yamlJson.services[svcName];
@@ -851,7 +851,7 @@
           };
 
           if (group.requirements.attributes) {
             group.requirements.attributes = group.requirements.attributes.sort((a: any, b: any) => a.key < b.key);
           }
 
           groups[group.name] = group;
@@ -863,7 +863,7 @@
           count: svcdepl.count
         };
 
         const endpoints = [] as any[];
         svc?.expose?.forEach(expose => {
           expose?.to
             ?.filter(to => to.global)

tests/__snapshots__/sdl_persistent_storage_attributes.spec.ts.snap

@@ -194,6 +194,22 @@ exports[`test sdl persistent storage SDL: Persistent Storage Manifest: SDL: Pers
                 "val": 1073741824,
               },
             },
+            {
+              "attributes": [
+                {
+                  "key": "class",
+                  "value": "ram",
+                },
+                {
+                  "key": "persistent",
+                  "value": "false",
+                },
+              ],
+              "name": "shm2",
+              "size": {
+                "val": 1073741824,
+              },
+            },
           ],
         },
         "params": {

tests/fixtures/persistent_storage_valid.sdl.yml

@@ -79,6 +79,11 @@ profiles:
             size: 1Gi
             attributes:
               class: ram
+          - name: shm2
+            size: 1Gi
+            attributes:
+              class: ram
+              persistent: false
   placement:
     akash:
       #######################################################