-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 517 (zombie processes in docker containers) #568
Conversation
Thank you for PR, @Dimokus88 ! The way it works is the added proccess manager - tini, which handles zombie processes now. @Dimokus88 before I merge, have you tested each of these deployments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've missed to add tini itself, i.e.
replace
/usr/local/bin/init.sh
to the relevant though
# Use tini as an init system to manage orphaned child processes, ensuring they
# don't become zombie (defunct) processes by reaping (cleaning up) them when
# their parent process doesn't.
# Tini will also correctly handle signals like SIGTERM (15), allowing child
# processes to terminate gracefully within the allotted time, rather than
# being forcefully killed with SIGKILL after a 15-second timeout.
ADD https://github.com/krallin/tini/releases/download/v0.19.0/tini /tini
RUN chmod +x /tini
ENTRYPOINT ["/tini", "--", "/usr/local/bin/init.sh"]
CMD ["tail", "-f", "/dev/null"]
Thx @andy108369 I was sure that it is present in ubuntu by default. |
Fixing issue 517 (zombie processes in docker containers)
@andy108369 found a way to fix zombie processes in docker containers by using
tail -f /dev/null
instead ofsleep infinity
which was used before.I changed some of the executable scripts according to his recommendation.