feat(deployment): improves sequelize error logging

also mocks Lease in deployment settings spec to avoid errors related to missing chain db migrations

refs #714

apps/api/src/core/services/hono-error-handler/hono-error-handler.service.ts

@@ -5,6 +5,7 @@ import type { Event } from "@sentry/types";
 import type { Context, Env } from "hono";
 import { isHttpError } from "http-errors";
 import omit from "lodash/omit";
+import { DatabaseError } from "sequelize";
 import { singleton } from "tsyringe";
 import { ZodError } from "zod";
 
@@ -26,7 +27,7 @@ export class HonoErrorHandlerService {
   }
 
   async handle<E extends Env = any>(error: Error, c: Context<E>): Promise<Response> {
-    this.logger.error(error);
+    this.logger.error(this.sequelizeErrorToObj(error));
 
     if (isHttpError(error)) {
       const { name } = error.constructor;
@@ -112,4 +113,17 @@ export class HonoErrorHandlerService {
         return undefined;
     }
   }
+
+  private sequelizeErrorToObj(error: unknown) {
+    if (error instanceof DatabaseError) {
+      return {
+        name: error.name,
+        message: error.message,
+        sql: error.sql,
+        stack: error.stack
+      };
+    }
+
+    return error;
+  }
 }

apps/api/test/functional/deployment-setting.spec.ts

@@ -3,7 +3,9 @@ import { container } from "tsyringe";
 
 import { app } from "@src/app";
 import { DeploymentSettingRepository } from "@src/deployment/repositories/deployment-setting/deployment-setting.repository";
+import { LeaseRepository } from "@src/deployment/repositories/lease/lease.repository";
 
+import { DrainingDeploymentSeeder } from "@test/seeders/draining-deployment.seeder";
 import { DbTestingService } from "@test/services/db-testing.service";
 import { WalletTestingService } from "@test/services/wallet-testing.service";
 
@@ -13,9 +15,15 @@ describe("Deployment Settings", () => {
   const dbService = container.resolve(DbTestingService);
   const walletService = new WalletTestingService(app);
   const deploymentSettingRepository = container.resolve(DeploymentSettingRepository);
+  const leaseRepository = container.resolve(LeaseRepository);
 
-  beforeEach(async () => {
+  beforeEach(() => {
+    jest.spyOn(leaseRepository, "findOneByDseqAndOwner").mockResolvedValue(DrainingDeploymentSeeder.create());
+  });
+
+  afterEach(async () => {
     await dbService.cleanAll();
+    jest.restoreAllMocks();
   });
 
   describe("GET /v1/deployment-settings/{userId}/{dseq}", () => {
@@ -94,6 +102,7 @@ describe("Deployment Settings", () => {
           topUpFrequencyMs: expect.any(Number)
         }
       });
+      expect(leaseRepository.findOneByDseqAndOwner).toHaveBeenCalledWith(dseq, user.id);
     });
   });
 
@@ -177,6 +186,7 @@ describe("Deployment Settings", () => {
         dseq,
         autoTopUpEnabled: true
       });
+      expect(leaseRepository.findOneByDseqAndOwner).toHaveBeenCalledWith(dseq, user.id);
     });
   });
 
@@ -229,6 +239,7 @@ describe("Deployment Settings", () => {
         dseq,
         autoTopUpEnabled: true
       });
+      expect(leaseRepository.findOneByDseqAndOwner).toHaveBeenCalledWith(dseq, user.id);
     });
 
     it("should return 404 when updating other user's deployment settings", async () => {
@@ -301,6 +312,7 @@ describe("Deployment Settings", () => {
         dseq,
         autoTopUpEnabled: true
       });
+      expect(leaseRepository.findOneByDseqAndOwner).toHaveBeenCalledWith(dseq, user.id);
     });
   });
 });