Feature/sdl #184
Feature/sdl #184
Conversation
ygrishajev
force-pushed
the
feature/sdl
branch
4 times, most recently
from
3ea323b to
4803bca
Compare
Also remove relevant local barrel index files. refs akash-network/support#184
There was a problem hiding this comment.
I see this file is not used anymore. Let's remove it?
| export let selectedNetworkId: string; | ||
|
|
||
| export function initDeploymentData() { |
There was a problem hiding this comment.
This was used to support different versions on different networks at the same time. Most of the time it's not used, but when new features are released on the sandbox for a few weeks, it's useful to have it.
There was a problem hiding this comment.
you mean, you manually update the code?
There was a problem hiding this comment.
Yes... I will revert it back to what it was.
There was a problem hiding this comment.
this is a funky way to do stuff. types and refs are lost this way I IDEs which can cause untraceable errors. there should be no dynamic exports
There was a problem hiding this comment.
smth like this would do much better
import * as v1beta3 from "./v1beta3";
import { mainnetId, testnetId, sandboxId } from "../constants";
import { getSelectedNetwork } from "@src/hooks/useSelectedNetwork";
import { NetworkId } from "@akashnetwork/akashjs/build/types/network";
export * from "./helpers";
const NETWORK_SDL: Record<NetworkId, typeof v1beta3> = {
[mainnetId]: v1beta3,
[testnetId]: v1beta3,
[sandboxId]: v1beta3
};
export let selectedNetwork = getSelectedNetwork();
export let selectedNetworkId = selectedNetwork.id;
export const deploymentData = NETWORK_SDL[selectedNetworkId];There was a problem hiding this comment.
Yea that works and looks better 👍
| try { | ||
| SDL.validate(yamlStr); | ||
| // TODO: use result of this in client code instead of just using validation |
There was a problem hiding this comment.
It's only called at one place in NewDeploymentData, maybe we can replace it there.
There was a problem hiding this comment.
Actually, getSdl is called multiple times DeploymentGroups Manifest ManifestVersion, perhaps there's a better to handle this.
There was a problem hiding this comment.
yes, definitely. I've just left it for the upcoming changes. When I move out all the validation it would be easier to streamline code duplication
to acquire credentials email default value assignment refs #133
## [0.9.1](v0.9.0...v0.9.1) (2024-05-14) ### Bug Fixes * **api:** rollback deprecated protobuf generated code ([4d2479d](4d2479d)), closes [akash-network/console#184](akash-network/console#184)
Changes:
Note: