Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/billing #289

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Feature/billing #289

merged 5 commits into from
Aug 8, 2024

Conversation

ygrishajev
Copy link
Contributor

No description provided.

baktun14
baktun14 reviewed Aug 7, 2024
View reviewed changes
apps/api/src/billing/services/master-signing-client/master-signing-client.service.ts
@@ -119,6 +123,15 @@ export class MasterSigningClientService {
const hashes = [...responses.map(hash => toHex(hash.hash)), lastDelivery.transactionHash];

return await Promise.all(hashes.map(hash => client.getTx(hash)));
} catch (error) {
if (error.message.includes("account sequence mismatch")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this happen a lot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it happened once to me

apps/deploy-web/src/context/WalletProvider/WalletProvider.tsx Outdated Show resolved Hide resolved
@baktun14
Copy link
Contributor

baktun14 commented Aug 7, 2024

There's currently no way to exit a trial and go back to self custody wallet. We could add the same (...) button with just one option to opt out of the trial and a confirmation?
image

@ygrishajev
Copy link
Contributor Author

There's currently no way to exit a trial and go back to self custody wallet. We could add the same (...) button with just one option to opt out of the trial and a confirmation? image

looks like a product decision generally. Let's discuss this with @anilmurty
in the meanwhile I don't really see any reason to add extra into this PR, the feature is incomplete anyway

@ygrishajev ygrishajev requested review from baktun14 and Redm4x August 7, 2024 11:07
@anilmurty
Copy link

Funn

There's currently no way to exit a trial and go back to self custody wallet. We could add the same (...) button with just one option to opt out of the trial and a confirmation? image

looks like a product decision generally. Let's discuss this with @anilmurty in the meanwhile I don't really see any reason to add extra into this PR, the feature is incomplete anyway

nice coincidence. I ran into that just this morning - was trying to show someone a demo of the "Start Trial" button and couldn't get back into that state after starting a trial. let's discuss for sure

@ygrishajev ygrishajev merged commit 0378ee4 into main Aug 8, 2024
5 checks passed
@ygrishajev ygrishajev deleted the feature/billing branch August 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baktun14 baktun14 baktun14 approved these changes

@Redm4x Redm4x Awaiting requested review from Redm4x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ygrishajev @baktun14 @anilmurty