-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(env): convert all env vars to SCREAMING_CASE from camelCase #335
Conversation
refs: #310 |
hey @hiroyukikumazawa looks like a bunch of envs are not updated here https://github.com/akash-network/console/blob/main/packages/database/chainDefinitions.ts Note: I found it's only |
Ok, I see |
@hiroyukikumazawa yea, that should do, thanks! I'd still like @Redm4x or @baktun14 to check this out too |
We only need akash related env var in this file. Others are to run the indexer for other chains, which we don't care for console. |
Hey @hiroyukikumazawa pls rebase and I'll deploy this to staging so everyone can test. Then we'll merge |
@hiroyukikumazawa any chance you could rebase soon? |
I will rebase now |
@hiroyukikumazawa I've done relevant changes in deploy-web last week, which change the location of configs and also renames vars to uppercase. Please accept 'main' changes in case of conflicts. Ref #355 |
ok |
81b47fa
to
bfbc86b
Compare
@ygrishajev please review again |
@hiroyukikumazawa I see another conflict, would you handle that? |
bfbc86b
to
faaf17c
Compare
@ygrishajev please check again |
@hiroyukikumazawa thanks a bunch! So I've deployed api to our beta and have indexer running locally. I'd like @Redm4x and @baktun14 to verify it once again and merge this. I'm going to squash commits on merge but you're welcome to do so yourself in the branch if you like so. Locally I have these vars set:
|
@ygrishajev was |
|
7b8edd2
to
82b5bad
Compare
@ygrishajev |
@ygrishajev done squash commit |
@hiroyukikumazawa https://github.com/akash-network/console/pull/335/files#diff-a7b12b4516cdcf3f8b1898a997e54d3b4a328a14bb80aecf30e2e23734e3a3a8R412 |
wdym? |
- update RestApiNodeUrl to REST_API_NODE_URL - update ServerOrigin to SERVER_ORIGIN - update HealthchecksEnabled to HEALTHCHECKS_ENABLED - update SentryDSN to SENTRY_DSN - update AkashDatabaseCS to AKASH_DATABASE_CS - update AkashTestnetDatabaseCS to AKASH_TESTNET_DATABASE_CS - update UserDatabaseCS to USER_DATABASE_CS - update AUTH0_JWKS_URI to AUTH0_JWKS_URI - update Auth0Audience to AUTH0_AUDIENCE - update Auth0Issuer to AUTH0_ISSUER - update StripeSecretKey to STRIPE_SECRET_KEY - update WebsiteUrl to WEBSITE_URL - update AkashlyticsGithubPAT to AKASHLYTICS_GITHUB_PAT - update SecretToken to SECRET_TOKEN - update AkashSandboxDatabaseCS to AKASH_SANDBOX_DATABASE_CS - update SentryDSN to SENTRY_DSN - update HealthChecks_SyncBlocks to HEALTHCHECKS_SYNC_BLOCKS - update HealthChecks_SyncAKTPriceHistory to HEALTHCHECKS_SYNC_AKT_PRICE_HISTORY - update HealthChecks_SyncProviderInfo to HEALTHCHECKS_SYNC_PROVIDER_INFO - update HealthChecks_SyncKeybaseInfo to HEALTHCHECKS_SYNC_KEYBASE_INFO - update AkashDatabaseCS to AKASH_DATABASE_CS - update ActiveChain to ACTIVE_CHAIN - update KeepCache to KEEP_CACHE - update Standby to STANDBY - update DataFolder to DATA_FOLDER - update JunoDatabaseCS to JUNO_DATABASE_CS - update PassageDatabaseCS to PASSAGE_DATABASE_CS - update HealthchecksEnabled to HEALTH_CHECKS_ENABLED - update SentryServerName to SENTRY_SERVER_NAME - update ProviderUptimeGracePeriodMinutes to PROVIDER_UPTIME_GRACE_PERIOD_MINUTES
82b5bad
to
cb580ff
Compare
No description provided.