Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env): convert all env vars to SCREAMING_CASE from camelCase #335

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

hiroyukikumazawa
Copy link
Contributor

No description provided.

@hiroyukikumazawa
Copy link
Contributor Author

refs: #310

@anilmurty anilmurty requested a review from ygrishajev August 23, 2024 14:00
@ygrishajev
Copy link
Contributor

hey @hiroyukikumazawa looks like a bunch of envs are not updated here https://github.com/akash-network/console/blob/main/packages/database/chainDefinitions.ts
Would be real nice if you kindly could check if the apps are at least starting without errors.

Note: I found it's only ActiveChain and it only affects indexer. @Redm4x @baktun14 are other used at all?

@ygrishajev ygrishajev requested review from Redm4x and baktun14 August 26, 2024 09:34
@hiroyukikumazawa
Copy link
Contributor Author

hiroyukikumazawa commented Aug 26, 2024

hey @hiroyukikumazawa looks like a bunch of envs are not updated here https://github.com/akash-network/console/blob/main/packages/database/chainDefinitions.ts Would be real nice if you kindly could check if the apps are at least starting without errors.

Note: I found it's only ActiveChain and it only affects indexer. @Redm4x @baktun14 are other used at all?

Ok, I see
And the apps projects are working correctly with this updates.
What about your side? @ygrishajev

@ygrishajev
Copy link
Contributor

hey @hiroyukikumazawa looks like a bunch of envs are not updated here https://github.com/akash-network/console/blob/main/packages/database/chainDefinitions.ts Would be real nice if you kindly could check if the apps are at least starting without errors.
Note: I found it's only ActiveChain and it only affects indexer. @Redm4x @baktun14 are other used at all?

Ok, I see And the apps projects are working correctly with this updates. What about your side? @ygrishajev

@hiroyukikumazawa yea, that should do, thanks! I'd still like @Redm4x or @baktun14 to check this out too

@baktun14
Copy link
Contributor

hey @hiroyukikumazawa looks like a bunch of envs are not updated here https://github.com/akash-network/console/blob/main/packages/database/chainDefinitions.ts Would be real nice if you kindly could check if the apps are at least starting without errors.

Note: I found it's only ActiveChain and it only affects indexer. @Redm4x @baktun14 are other used at all?

We only need akash related env var in this file. Others are to run the indexer for other chains, which we don't care for console.

@ygrishajev
Copy link
Contributor

Hey @hiroyukikumazawa pls rebase and I'll deploy this to staging so everyone can test. Then we'll merge

@ygrishajev
Copy link
Contributor

@hiroyukikumazawa any chance you could rebase soon?

@hiroyukikumazawa
Copy link
Contributor Author

We only need akash related env var in this file. Others are to run the indexer for other chains, which we don't care for console

I will rebase now

@ygrishajev
Copy link
Contributor

ygrishajev commented Sep 9, 2024

@hiroyukikumazawa I've done relevant changes in deploy-web last week, which change the location of configs and also renames vars to uppercase. Please accept 'main' changes in case of conflicts.

Ref #355

@hiroyukikumazawa
Copy link
Contributor Author

@hiroyukikumazawa I've done relevant changes in deploy-web last week, which change the location of configs and also renames vars to uppercase. Please accept 'main' changes in case of conflicts.

ok

@hiroyukikumazawa
Copy link
Contributor Author

@ygrishajev please review again

@ygrishajev
Copy link
Contributor

@hiroyukikumazawa I see another conflict, would you handle that?

@hiroyukikumazawa
Copy link
Contributor Author

@ygrishajev please check again

@ygrishajev
Copy link
Contributor

@hiroyukikumazawa thanks a bunch! So I've deployed api to our beta and have indexer running locally. I'd like @Redm4x and @baktun14 to verify it once again and merge this.

I'm going to squash commits on merge but you're welcome to do so yourself in the branch if you like so.

Locally I have these vars set:

ACTIVE_CHAIN=akashSandbox
AKASH_DATABASE_CS=postgres://postgres:password@db:5432/console-akash-sandbox
ActiveChain=akashSandbox
image

@hiroyukikumazawa
Copy link
Contributor Author

hiroyukikumazawa commented Sep 10, 2024

ActiveChain

@ygrishajev was ActiveChain=akashSandbox needed in indexer?

@ygrishajev
Copy link
Contributor

ActiveChain

@ygrishajev was ActiveChain=akashSandbox needed in indexer?

oh, indeed I found a bunch of them used
image

@hiroyukikumazawa hiroyukikumazawa force-pushed the issues/310 branch 2 times, most recently from 7b8edd2 to 82b5bad Compare September 10, 2024 08:42
@hiroyukikumazawa
Copy link
Contributor Author

hiroyukikumazawa commented Sep 10, 2024

@ygrishajev
I thought activeChain is not a env var.
Instead, ActiveChain is in the readme.
And in my local, without ActiveChain env var it's working.

@hiroyukikumazawa
Copy link
Contributor Author

@ygrishajev done squash commit

@ygrishajev
Copy link
Contributor

@ygrishajev I thought activeChain is not a env var. Instead, ActiveChain is in the readme. And in my local, without ActiveChain env var it's working.

@hiroyukikumazawa https://github.com/akash-network/console/pull/335/files#diff-a7b12b4516cdcf3f8b1898a997e54d3b4a328a14bb80aecf30e2e23734e3a3a8R412

@hiroyukikumazawa
Copy link
Contributor Author

@ygrishajev I thought activeChain is not a env var. Instead, ActiveChain is in the readme. And in my local, without ActiveChain env var it's working.

@hiroyukikumazawa https://github.com/akash-network/console/pull/335/files#diff-a7b12b4516cdcf3f8b1898a997e54d3b4a328a14bb80aecf30e2e23734e3a3a8R412

wdym?

apps/api/src/utils/env.ts Outdated Show resolved Hide resolved
- update RestApiNodeUrl to REST_API_NODE_URL

- update ServerOrigin to SERVER_ORIGIN

- update HealthchecksEnabled to HEALTHCHECKS_ENABLED

- update SentryDSN to SENTRY_DSN

- update AkashDatabaseCS to AKASH_DATABASE_CS

- update AkashTestnetDatabaseCS to AKASH_TESTNET_DATABASE_CS

- update UserDatabaseCS to USER_DATABASE_CS

- update AUTH0_JWKS_URI to AUTH0_JWKS_URI

- update Auth0Audience to AUTH0_AUDIENCE

- update Auth0Issuer to AUTH0_ISSUER

- update StripeSecretKey to STRIPE_SECRET_KEY

- update WebsiteUrl to WEBSITE_URL

- update AkashlyticsGithubPAT to AKASHLYTICS_GITHUB_PAT

- update SecretToken to SECRET_TOKEN

- update AkashSandboxDatabaseCS to AKASH_SANDBOX_DATABASE_CS

- update SentryDSN to SENTRY_DSN

- update HealthChecks_SyncBlocks to HEALTHCHECKS_SYNC_BLOCKS

- update HealthChecks_SyncAKTPriceHistory to HEALTHCHECKS_SYNC_AKT_PRICE_HISTORY

- update HealthChecks_SyncProviderInfo to HEALTHCHECKS_SYNC_PROVIDER_INFO

- update HealthChecks_SyncKeybaseInfo to HEALTHCHECKS_SYNC_KEYBASE_INFO

- update AkashDatabaseCS to AKASH_DATABASE_CS

- update ActiveChain to ACTIVE_CHAIN

- update KeepCache to KEEP_CACHE

- update Standby to STANDBY

- update DataFolder to DATA_FOLDER

- update JunoDatabaseCS to JUNO_DATABASE_CS

- update PassageDatabaseCS to PASSAGE_DATABASE_CS

- update HealthchecksEnabled to HEALTH_CHECKS_ENABLED

- update SentryServerName to SENTRY_SERVER_NAME

- update ProviderUptimeGracePeriodMinutes to PROVIDER_UPTIME_GRACE_PERIOD_MINUTES
@Redm4x Redm4x merged commit 1e892ee into akash-network:main Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants