Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): balance authz deployments #359

Merged
merged 13 commits into from
Sep 10, 2024

Conversation

baktun14
Copy link
Contributor

@baktun14 baktun14 commented Sep 9, 2024

  • Refactored how we fetch the balances into a single hook
  • Improved the display in "Your Account" panel for managed wallets
  • Added a modal to explain the escrow accounts/deployments for managed wallets
  • Added a warning in the create deployment confirmation when insufficient funds

image
image
image
image

@baktun14 baktun14 force-pushed the features/console-balance-authz-deployments branch from 6ad3d1d to 809f761 Compare September 9, 2024 18:14
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I've got quite some comments. It's obviously up to you which ones to apply and I'm happy to discuss if needed

apps/deploy-web/src/hooks/useWalletBalance.ts Show resolved Hide resolved
apps/deploy-web/src/hooks/useWalletBalance.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/hooks/useWalletBalance.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/hooks/useWalletBalance.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/hooks/useWalletBalance.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/hooks/useWalletBalance.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/queries/useBalancesQuery.ts Outdated Show resolved Hide resolved
@baktun14 baktun14 merged commit abdb18a into main Sep 10, 2024
5 checks passed
@baktun14 baktun14 deleted the features/console-balance-authz-deployments branch September 10, 2024 19:39
@baktun14 baktun14 mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants