-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): balance authz deployments #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baktun14
commented
Sep 9, 2024
- Refactored how we fetch the balances into a single hook
- Improved the display in "Your Account" panel for managed wallets
- Added a modal to explain the escrow accounts/deployments for managed wallets
- Added a warning in the create deployment confirmation when insufficient funds
… + display for your account and wallet status
baktun14
force-pushed
the
features/console-balance-authz-deployments
branch
from
September 9, 2024 18:14
6ad3d1d
to
809f761
Compare
ygrishajev
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although I've got quite some comments. It's obviously up to you which ones to apply and I'm happy to discuss if needed
apps/deploy-web/src/components/shared/ManagedEscrowFaqModal.tsx
Outdated
Show resolved
Hide resolved
ygrishajev
approved these changes
Sep 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.