-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdl): can set credentials #479
feat(sdl): can set credentials #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The credentials for private repos are optional, since not all repos are private. The way you implemented it is great, we just need to add a flag like "hasGpu" and conditionally add the validation. So a simple checkbox like the hasGpu
to toggle the form controls should do it.
Is there a reason behind the canChangeCredentials
? We would like to have it in all the SDL builder instances (SDL Builder page and new deployment page).
export const defaultService: ServiceType = { | ||
id: nanoid(), | ||
title: "service-1", | ||
image: "", | ||
credentials: defaultCredentials, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is throwing and error in the build as the username
and password
are required.
I added the flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it locally and it works great, great work!
One can select an image repository and enter credentials after this. Available in the SDL Builder, but not in the deployment UI.
ref #467