Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdl): can set credentials #479

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Nov 18, 2024

One can select an image repository and enter credentials after this. Available in the SDL Builder, but not in the deployment UI.

ref #467

@jzsfkzm jzsfkzm requested a review from a team as a code owner November 18, 2024 07:59
Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The credentials for private repos are optional, since not all repos are private. The way you implemented it is great, we just need to add a flag like "hasGpu" and conditionally add the validation. So a simple checkbox like the hasGpu to toggle the form controls should do it.

Is there a reason behind the canChangeCredentials? We would like to have it in all the SDL builder instances (SDL Builder page and new deployment page).

export const defaultService: ServiceType = {
id: nanoid(),
title: "service-1",
image: "",
credentials: defaultCredentials,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is throwing and error in the build as the username and password are required.

@jzsfkzm
Copy link
Contributor Author

jzsfkzm commented Nov 19, 2024

The credentials for private repos are optional, since not all repos are private. The way you implemented it is great, we just need to add a flag like "hasGpu" and conditionally add the validation. So a simple checkbox like the hasGpu to toggle the form controls should do it.

Is there a reason behind the canChangeCredentials? We would like to have it in all the SDL builder instances (SDL Builder page and new deployment page).

I added the flag canChangeCredentials because I figured it is not needed for templates on the Deploy page. Now I see it is very much needed there too, so removed. Now it is all the same for Deploy and SDL Builder.
Added a checkbox with label "Private" on top the box, revealing credential fields only when you click it.

Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it locally and it works great, great work!

@baktun14 baktun14 merged commit 95a6e2b into akash-network:main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants