Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deployment): managed wallet user template #483

Merged
merged 11 commits into from
Nov 19, 2024
Merged

fix(deployment): managed wallet user template #483

merged 11 commits into from
Nov 19, 2024

Conversation

baktun14
Copy link
Contributor

  • fix: routing issue with history.replaceState
  • fix: managed wallet user template can't edit
  • fix: mobile bid list display
  • fix: mobile wallet display

@baktun14 baktun14 requested a review from a team as a code owner November 19, 2024 15:25
ygrishajev
ygrishajev approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments are not blocking. imo just would make code a bit simpler to read generally

apps/deploy-web/src/components/new-deployment/NewDeploymentContainer.tsx Show resolved Hide resolved
apps/deploy-web/src/components/new-deployment/NewDeploymentContainer.tsx Outdated Show resolved Hide resolved
@baktun14 baktun14 merged commit ab83f2f into main Nov 19, 2024
5 checks passed
@baktun14 baktun14 deleted the bugfixes/managed-wallet-user-template branch November 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygrishajev ygrishajev ygrishajev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baktun14 @ygrishajev