Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): reworks top up deployments to rely on db setting #738

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ygrishajev
Copy link
Contributor

refs #714

@ygrishajev ygrishajev requested a review from a team as a code owner January 28, 2025 17:51
baktun14
baktun14 previously approved these changes Jan 28, 2025
@ygrishajev ygrishajev force-pushed the feature/deployment branch 3 times, most recently from fa044a7 to 2e40d2b Compare January 31, 2025 11:15
@ygrishajev ygrishajev changed the title feat(deployment): creates deployment settings table feat(deployment): reworks top up deployments to rely on db setting Jan 31, 2025
@ygrishajev ygrishajev force-pushed the feature/deployment branch 2 times, most recently from 33167c7 to bedfc61 Compare January 31, 2025 11:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 83.94161% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9723093). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...eployment-setting/deployment-setting.repository.ts 37.50% 13 Missing and 2 partials ⚠️
.../deployment/repositories/lease/lease.repository.ts 0.00% 2 Missing and 1 partial ⚠️
...ces/deployment-config/deployment-config.service.ts 66.66% 2 Missing ⚠️
...as/deployment-setting/deployment-setting.schema.ts 80.00% 1 Missing ⚠️
...-deployments/top-up-managed-deployments.service.ts 97.36% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage        ?   50.42%           
=======================================
  Files           ?      202           
  Lines           ?     4567           
  Branches        ?      683           
=======================================
  Hits            ?     2303           
  Misses          ?     2090           
  Partials        ?      174           
Flag Coverage Δ
api 50.42% <83.94%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ygrishajev ygrishajev force-pushed the feature/deployment branch 3 times, most recently from 6d05bd6 to 852fdbd Compare January 31, 2025 14:05
@ygrishajev ygrishajev requested a review from baktun14 January 31, 2025 14:33
@ygrishajev ygrishajev requested a review from a team January 31, 2025 14:33
Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So when users will enable the feature, we'll either create or update the DeploymentSetting?

@ygrishajev
Copy link
Contributor Author

Nice! So when users will enable the feature, we'll either create or update the DeploymentSetting?

Yea, will work on that next. I want to update the setting manually and test the job first

@ygrishajev ygrishajev merged commit 2762b97 into main Feb 3, 2025
5 checks passed
@ygrishajev ygrishajev deleted the feature/deployment branch February 3, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants