Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(billing): functional tests for Stripe webhook #744

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Jan 29, 2025

refs #719

@jzsfkzm jzsfkzm requested a review from a team as a code owner January 29, 2025 12:27
@ygrishajev
Copy link
Contributor

ygrishajev commented Jan 29, 2025

blocking: looks like you don't have git hooks installed. I think there was an issue before. You might need to run npm run prepare to set husky up. The conventional commit lint wouldn't allow webhook scope. There's another one we use for this: billing

@jzsfkzm jzsfkzm force-pushed the feat/webhook-tests branch 2 times, most recently from e7c9947 to 1f35abe Compare January 29, 2025 15:04
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! let's just change commit scope pls and discuss other stu

@jzsfkzm jzsfkzm changed the title test(webhook): functional tests for Stripe webhook test(billing): functional tests for Stripe webhook Jan 29, 2025
@jzsfkzm
Copy link
Contributor Author

jzsfkzm commented Jan 29, 2025

lgtm! let's just change commit scope pls and discuss other stu

Ah, I did already, just the PR title needed a manual update too. Now it's also done.

@jzsfkzm jzsfkzm force-pushed the feat/webhook-tests branch from 1f35abe to 0d87729 Compare January 29, 2025 21:16
@jzsfkzm jzsfkzm force-pushed the feat/webhook-tests branch from 0d87729 to 0a4c618 Compare January 29, 2025 21:28
@ygrishajev ygrishajev merged commit 34b2e36 into akash-network:main Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants