Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): creates setting if not exists on get #808

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ygrishajev
Copy link
Contributor

refs #714

@ygrishajev ygrishajev requested a review from a team as a code owner February 6, 2025 14:50
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.64%. Comparing base (8fc4523) to head (c7d3a3a).

Files with missing lines Patch % Lines
...s/deployment-setting/deployment-setting.service.ts 88.88% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8fc4523) and HEAD (c7d3a3a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8fc4523) HEAD (c7d3a3a)
provider-proxy 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #808       +/-   ##
===========================================
- Coverage   80.87%   51.64%   -29.23%     
===========================================
  Files          12      206      +194     
  Lines         413     4684     +4271     
  Branches       75      695      +620     
===========================================
+ Hits          334     2419     +2085     
- Misses         78     2254     +2176     
- Partials        1       11       +10     
Flag Coverage Δ
api 51.64% <91.66%> (?)
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ygrishajev ygrishajev merged commit 66cd74b into main Feb 7, 2025
6 checks passed
@ygrishajev ygrishajev deleted the feature/deployment branch February 7, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants