Optimize USDC deployment flow #97

ygrishajev · 2024-02-13T20:46:12Z

This PR is addressing issue #63.

fixes update propagation from the placement modal form to SDL page.
changes action button text from Close to Done which semantically suggests that modal changes are already applied. This seems the most optimal way atm as "save" functionality implementation would be a comparably much more effort
moves token select from placement modal to SDL root view

Updated SDL root view

Updated placement modal

From Close to Done which semantically suggests that modal changes are applied

deploy-web/src/components/sdl/PlacementFormModal.tsx

deploy-web/src/components/sdl/RentGpusForm.tsx

deploy-web/src/components/sdl/TokenFormControl.tsx

deploy-web/src/components/sdl/SimpleServiceFormControl.tsx

baktun14 · 2024-02-13T23:54:41Z

This is great! 🚀

One last thing, there was a bug when changing the token it doesn't reflect in the generated SDL and transaction.

We call the function generateSdl here, it's somewhere in there.

ygrishajev · 2024-02-14T08:09:47Z

One last thing

baktun14 · 2024-02-14T15:11:29Z

Awesome, lgtm! I'll merge it later today.

ygrishajev added 3 commits February 13, 2024 21:21

Fix SDL pricing message update on placement token change (#63)

3a64bb2

Change placement modal action button text (#63)

a74da25

From Close to Done which semantically suggests that modal changes are applied

Move token select from placement modal to SDL builder (#63)

46219cd