Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade IBC & lint #1823

Closed
wants to merge 6 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 23, 2023

Description

Note: this doesn't comply with conventional commits yet, I could squash it to make it do that, though.

  • upgrade ibc to v4.4.0
  • lint the repository a bit more tightly

Lately I've been interested in making a "platform of chains" and the big blocker is the fact that all of them are a little bit different. The .proto types and interfaces in 47+ have improved a great deal, and that's likely possible now, and usually before bringing the whole thing to 47, I lint the heck out of it to make sure any issues are easier to spot.

Summary:

  • upgrade many chains to 47
  • make a single front end for may chains, interactive

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@faddat faddat marked this pull request as ready for review May 23, 2023 04:41
@faddat faddat requested a review from a team as a code owner May 23, 2023 04:41
@faddat faddat marked this pull request as draft May 23, 2023 05:10
@troian
Copy link
Member

troian commented May 23, 2023

hey @faddat, could you split PR into a few atomic pieces.
the very first would be to upgrade ibc-go to v4

@faddat
Copy link
Contributor Author

faddat commented May 24, 2023

yes, absolutely

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Marked as stale; will be closed in five days.

Cut bait or go fishing!

@github-actions github-actions bot added the stale label Jun 4, 2023
@github-actions github-actions bot closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants