Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Watecco Triphaso #240

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Added Watecco Triphaso #240

merged 13 commits into from
Oct 4, 2024

Conversation

J2thatsme
Copy link
Contributor

No description provided.

mariusgiger
mariusgiger requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@mariusgiger mariusgiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please review the commented sections once more, also there is a case where no output is emitted

types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
mariusgiger
mariusgiger reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@mariusgiger mariusgiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update - please check this one again, there seem to be one or two things to follow up

types/watecco/triphaso/phase_a.schema.json Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/uplink.js Outdated Show resolved Hide resolved
types/watecco/triphaso/variables.schema.json Outdated Show resolved Hide resolved
@J2thatsme J2thatsme closed this Aug 7, 2024
@J2thatsme J2thatsme reopened this Aug 7, 2024
@J2thatsme J2thatsme merged commit f3d1375 into main Oct 4, 2024
4 of 5 checks passed
@J2thatsme J2thatsme deleted the triphaso branch October 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusgiger mariusgiger mariusgiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J2thatsme @mariusgiger