Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi packaging + more #54

Open
wants to merge 6 commits into
base: phase0
Choose a base branch
from
Open

Pypi packaging + more #54

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2017

Hi,
I guess I just let myself be carried away a little bit with this packaging thing:)

I changed a lot of things. Mainly in file structure, I split some files to more smaler ones. But now we have true Python package. \o/

Here are some things I've done:

  • Now, when you install the package, you will have aker and akerctl commands available in your system. It is same as running python -m aker.cli.aker or python -m aker.cli.akerctl from project dir
  • To achieve this I moved part of original aker.py to aker/aker.py and aker/cli/aker.py.
  • For akerctl.py I did something similar, spitting it to aker/commands.py and aker/cli/akerctl.py
  • I removed pyte directory and added it as proper dependency to requirements.txt.
  • I fixed logging - no more .format() in logging messages - use proper way of %s and passing variables as arguments
  • I fixed argparse related things, added few arguments to akerctl
  • I added dir for tests
  • This PR contains also changes introduced in PR Allow cli args for aker.py. Refactoring. Readme #51

I tried to record and replay the session using aker.idp.json.Json provider - all was ok.

Please let me know if anything seems weird to you so we can change it before merging:)

@anazmy
Copy link
Contributor

anazmy commented Nov 29, 2017

man!! that's marvelous

Let me spin a test environment to test all these stuff

@ghost
Copy link
Author

ghost commented Nov 29, 2017

I will close #51 since it is included in this one too. I wanted to separate my work to smaller PRs but in the end it is one huge:) Sorry..

@anazmy
Copy link
Contributor

anazmy commented Nov 30, 2017

I did a couple of tests, things seems fine but I need to run some more tests, I think I might put this in a separate branch till I pypi upload is done and I modify my install playbook.

Ah, and I need to add some bugfixes and enhancements unrelated to your changes as well.

Many thanks for the contribution, if you have other ideas to add please let me know.

@ghost ghost mentioned this pull request Nov 30, 2017
@ghost
Copy link
Author

ghost commented Dec 6, 2017

Hi, how is testing going? Do you have any idea when this is gonna be merged?

@anazmy
Copy link
Contributor

anazmy commented Dec 6, 2017

Hey there, apologies for the delays, I got hooked up in some stuff in my day job, will wrap it up and will get back to this, hopefully this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant