Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Indefinite to Unlimited #485

Merged
merged 2 commits into from
Oct 17, 2024
Merged

refactor: rename Indefinite to Unlimited #485

merged 2 commits into from
Oct 17, 2024

Conversation

ozyx
Copy link
Collaborator

@ozyx ozyx commented Oct 14, 2024

Partially addresses VIPERGC-574

Describe your changes:

  • Renames 'Indefinite' to 'Unlimited' shelve duration to be inline with YAMCS interface.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:bug Something isn't working label Oct 14, 2024
@ozyx ozyx added this to the build9-rc11 milestone Oct 14, 2024
@akhenry akhenry merged commit b83331a into master Oct 17, 2024
9 checks passed
@akhenry
Copy link
Owner

akhenry commented Oct 17, 2024

Tested locally, looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants