Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and cmake warnings #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AbstractFactory/cpp-source/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.5)
project(IsaacAbstractFactory)

add_executable(AbstractFactory main.cpp)
Expand All @@ -13,4 +13,4 @@ target_link_libraries(AbstractFactory ${ADDITIONAL_LIBRARIES})

add_executable(AbstractFactorySerializer main_serializer.cpp ${SOURCES} ${HEADERS})
target_include_directories(AbstractFactorySerializer PRIVATE rooms serializers factories)
target_link_libraries(AbstractFactorySerializer ${ADDITIONAL_LIBRARIES})
target_link_libraries(AbstractFactorySerializer ${ADDITIONAL_LIBRARIES})
2 changes: 1 addition & 1 deletion AbstractFactory/cpp-source/factories/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.5)
project(IsaacFactories)

set(SOURCES BasementFactory.cpp CavesFactory.cpp RoomFactory.cpp)
Expand Down
2 changes: 1 addition & 1 deletion AbstractFactory/cpp-source/rooms/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.5)

project(IsaacRooms)

Expand Down
2 changes: 1 addition & 1 deletion AbstractFactory/cpp-source/serializers/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.5)
project(Serializers)

set(SOURCES ../rooms/HardRoom.cpp ../rooms/NormalRoom.cpp ../rooms/Room.cpp RoomSerializer.cpp RoomSerializer.h GameSerializer.cpp GameSerializer.h)
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.5)


option(ON_PI "Build on PI" OFF)
Expand Down
1 change: 1 addition & 0 deletions Command/cpp-source/commands/Command.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#pragma once

#include <string>
#include <cstdint>

class Command {
public:
Expand Down
4 changes: 2 additions & 2 deletions Decorator/cpp-source/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.5)

project(Decorator)

Expand Down Expand Up @@ -77,4 +77,4 @@ add_custom_target(
copy_configs ALL DEPENDS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/configs/config.ini
)

add_dependencies(Decorator copy_configs)
add_dependencies(Decorator copy_configs)
2 changes: 1 addition & 1 deletion Facade/cpp-source/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.5)
project(Facade)

add_executable(
Expand Down
2 changes: 1 addition & 1 deletion FactoryMethod/cpp-source/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.5)
project(FactoryMethod)

set(
Expand Down
1 change: 1 addition & 0 deletions Memento/cpp-source/Memento.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#pragma once

#include <string>
#include <cstdint>

namespace memento {

Expand Down
3 changes: 2 additions & 1 deletion Observer/cpp-source/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <string>
#include <thread>
#include <mutex>
#include <memory>

struct MessageStorage {
std::queue<std::string> messages;
Expand Down Expand Up @@ -72,4 +73,4 @@ int main() {
std::thread t2(ProcessMessages, std::ref(p1));
t1.join();
t2.join();
}
}