fix: Avoid start of ShardedDaemonProcess for old revision #32850
+92
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patriknw
commented
Nov 25, 2025
patriknw
commented
- when rescaling the revision is bumped, and all previous processes are stopped
- if a keep-alive message is in flight that can trigger a new start of a process that belongs to the previous revision, because the revision check was using local read consistency
- change to use same consistency as the ShardedDaemonProcessCoordinator
* when rescaling the revision is bumped, and all previous processes are stopped * if a keep-alive message is in flight that can trigger a new start of a process that belongs to the previous revision, because the revision check was using local read consistency * change to use same consistency as the ShardedDaemonProcessCoordinator
patriknw
force-pushed
the
wip-daemon-start-patriknw
branch
from
4e6dd6b to
9e7c9e9
Compare
patriknw
commented
Nov 25, 2025
| def apply(id: Int): Behavior[Command] = Behaviors.setup { ctx => | ||
| ctx.log.info("Started [{}]", id) | ||
| val snitchRouter = ctx.spawn(Routers.group(SnitchServiceKey), "router") | ||
| snitchRouter ! ProcessActorEvent(id, "Started") |
Contributor
Author
There was a problem hiding this comment.
This is not reliable, sometimes dead letters. I have to find a better way to collect these events.
Contributor
There was a problem hiding this comment.
Why would it drop messages?
octonato
approved these changes
Nov 25, 2025
Contributor
octonato
left a comment
octonato
left a comment
There was a problem hiding this comment.
LTGM, with a question...
| def apply(id: Int): Behavior[Command] = Behaviors.setup { ctx => | ||
| ctx.log.info("Started [{}]", id) | ||
| val snitchRouter = ctx.spawn(Routers.group(SnitchServiceKey), "router") | ||
| snitchRouter ! ProcessActorEvent(id, "Started") |
Contributor
There was a problem hiding this comment.
Why would it drop messages?
johanandren
approved these changes
Nov 25, 2025
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
Fix looks good.
Not good idea why the group router would drop messages.
Contributor
Author
|
draft until the test is solid |
Contributor
Author
|
I'll improve the test in a separate follow up PR. We have confirmed this in running systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.