feat: Utility for passing debug correlation id to query implementations #32851
+140
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Dec 1, 2025
| * Expected to be used "around" calls to plugin query method, will clear the correlation id from thread local | ||
| * to make sure there is no leak between logic executed on shared threads. | ||
| */ | ||
| def withCorrelationId[T](correlationId: String)(block: () => T): T = { |
Contributor
There was a problem hiding this comment.
we'll probably only use this ourselves, with Scala, but shall we think about if it works for Java if we are making it public?
Contributor
Author
There was a problem hiding this comment.
Good point. We could mark it as internal, but it will need to be binary compatible either way so I thought it can just as well be public API
|
|
||
| /** | ||
| * @return Expected to be called directly after receiving a query call, before starting any asynchronous tasks, | ||
| * returns and clears out the correlation id to make sure there is no leak between tasks. Further passing |
Contributor
There was a problem hiding this comment.
this method doesn't "clears out"
Contributor
Author
There was a problem hiding this comment.
Ups, leftover from previous iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.