docs: revise URL structure (libraries) #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The link validator failure is expected. |
johanandren
approved these changes
Sep 24, 2024
| # https://github.com/coursier/setup-action/releases | ||
| # v1.3.5 | ||
| uses: coursier/setup-action@7bde40eee928896f074dbb76d22dd772eed5c65f | ||
| with: | ||
| jvm: temurin:1.11 | ||
| jvm: temurin:1.17 |
There was a problem hiding this comment.
Don't we want to stay on 11 as long as we support it to be sure we don't publish artifacts with the wrong target? (And if not, why not go for 21 right away?)
There was a problem hiding this comment.
This is only for the docs. With JPMS the Java API doc links changed.
Could go to 21 for that, but more across the board.
There was a problem hiding this comment.
Ah, missed that it was only about the docs, then it is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librariesReferences