make scan less aggressive, #847 #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Dec 7, 2020
| @@ -109,14 +109,13 @@ import akka.stream.alpakka.cassandra.scaladsl.CassandraSession | |||
| } | |||
| acc + (pid -> ((newTagPidSequenceNr, newTimestamp))) | |||
| } | |||
| .flatMap { result => | |||
| if (deadline.hasTimeLeft()) { | |||
| doIt() | |||
There was a problem hiding this comment.
@chbatey What do you think about this? As far as I can see it's just throwing away earlier results.
There was a problem hiding this comment.
I think the initial thought was the scan would take some time so the timeout would have met by the first time it came back
chbatey
approved these changes
Dec 7, 2020
| @@ -109,14 +109,13 @@ import akka.stream.alpakka.cassandra.scaladsl.CassandraSession | |||
| } | |||
| acc + (pid -> ((newTagPidSequenceNr, newTimestamp))) | |||
| } | |||
| .flatMap { result => | |||
| if (deadline.hasTimeLeft()) { | |||
| doIt() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #847