Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't call change handler if optimistic lock fails #484

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: Don't call change handler if optimistic lock fails #484

merged 1 commit into from
Dec 7, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Dec 7, 2023

  • the check and throw is outside the transaction
  • I don't see the need for rollback, though

@patriknw
fix: Don't call change handler if optimistic lock fails
3994e07 
* the check and throw is outside the transaction
* I don't see the need for rollback, though
@patriknw patriknw added the bug Something isn't working label Dec 7, 2023
@johanandren johanandren merged commit 2a39adc into main Dec 7, 2023
7 checks passed
@johanandren johanandren deleted the wip-check-in-tx-patriknw branch December 7, 2023 15:12
@johanandren johanandren added this to the 1.2.1 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@patriknw @johanandren