feat: Migration of Durable State, #504 #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding Durable State to the MigrationTool * currently doesn't support retrieval of all persistenceIds because the jdbc plugin doesn't implement PersistenceIdsQuery, and jdbc plugin is currently the only other know plugin for durable state
johanandren
reviewed
Jan 22, 2024
migration/src/main/scala/akka/persistence/r2dbc/migration/MigrationTool.scala
Show resolved
Hide resolved
| Some(serializedState), | ||
| stateSerializer.identifier, | ||
| stateManifest, | ||
| tags = Set.empty // not possible to preserve tags |
There was a problem hiding this comment.
Is that a separate table in JDBC or why?
There was a problem hiding this comment.
we use the the DurableStateStore api, so it's not tied to jdbc plugin specifically, and from that we don't get the timestamp
There was a problem hiding this comment.
I answered above question about timestamp, but same answer for tags
|
|
||
| private def loadSourceDurableState(persistenceId: String, minRevision: Long): Future[Option[SelectedDurableState]] = { | ||
| if (sourceDurableStatePluginId == "") | ||
| Future.successful(None) |
There was a problem hiding this comment.
Isn't that an error rather, misconfiguration?
There was a problem hiding this comment.
default value from reference.conf is
durable-state-plugin-id = "jdbc-durable-state-store"
There was a problem hiding this comment.
well, maybe this check is copy pasta from snapshot migration. I think it can be removed
migration/src/main/scala/akka/persistence/r2dbc/migration/MigrationTool.scala
Outdated
Show resolved
Hide resolved
johanandren
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #504