Skip to content

Conversation

Arkatufus
Copy link
Contributor

Changes

Add JournalOptions.SupervisorStrategy and SnapshotOptions.SupervisorStrategy options that was added to Akka v1.5.42

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just assign a SupervisionStrategy directly?

@Arkatufus
Copy link
Contributor Author

Because the way it is set up in Akka, it requires a SupervisorStrategyConfigurator

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal is to assign a supervisor strategy

  • the SupervisorConfigurator or whatever it's called is a hack we have to have in order to get HOCON to work.
  • We can just do the SupervisorStrategy directly here and generate the configurator for it. That would be the DX-friendly way to do this.

@Arkatufus
Copy link
Contributor Author

Arkatufus commented May 28, 2025

Yes, but that is not how the supervisor strategy being loaded from HOCON the HOCON loader requires that the type being passed in as a SupervisorStrategyConfigurator or it will throw. If you want to do that, we have to change how it is done in Akka.Persistence first.

@Arkatufus
Copy link
Contributor Author

Arkatufus commented May 28, 2025

We can't just "generate" a configurator because it still needs to be loaded from HOCON in the end. And as you said, "the SupervisorConfigurator or whatever it's called is a hack we have to have in order to get HOCON to work". You mean actually use code generator to make a class during compilation time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants