[14.0] [FIX] pos_sale_order: Fix deadlock on session close with a payment method without journal #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod without journal
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #69 +/- ##
==========================================
- Coverage 88.73% 88.58% -0.16%
==========================================
Files 51 51
Lines 1012 1016 +4
Branches 158 159 +1
==========================================
+ Hits 898 900 +2
- Misses 98 99 +1
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should at least allow setting a journal, otherwise the session can't be close since there is no journal and journal can't be set since there's an open session.