Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in output for few cases #27

Open
vikasgandham opened this issue Jun 15, 2018 · 1 comment · May be fixed by #34
Open

Error in output for few cases #27

vikasgandham opened this issue Jun 15, 2018 · 1 comment · May be fixed by #34
Labels
bug

Comments

@vikasgandham
Copy link

Example

print(w2n.word_to_num("one million eighty two thousand"))
1083160

print(w2n.word_to_num("one million one hundred and eighty two thousand"))
1182001
@akshaynagpal
Copy link
Owner

Thanks for pointing this out. I will look into this ASAP.
Meanwhile, you're also welcome to fix the error and submit a Pull Request. If it passes all the tests, it will be merged most probably.

poneill pushed a commit to poneill/w2n that referenced this issue Mar 18, 2019
add some failing tests to cover cases raised issue akshaynagpal#27
aa57851
@poneill poneill linked a pull request Mar 18, 2019 that will close this issue
Open
@frootbirb frootbirb mentioned this issue Nov 10, 2020
Open
@bastie bastie mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor handling of three digit groups poneill/w2n
2 participants
@vikasgandham @akshaynagpal