Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of three digit groups #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

poneill
Copy link

@poneill poneill commented Mar 18, 2019

Hi,

I've tried to refactor the handling of three digit groups a bit, and I've added a few tests to cover cases that were previously handled incorrectly. This fixes #27 (and possibly others?)

Cheers,
Pat.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34 into master will increase coverage by 1.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage    96.8%   98.31%   +1.51%     
==========================================
  Files           2        2              
  Lines         125      119       -6     
==========================================
- Hits          121      117       -4     
+ Misses          4        2       -2
Impacted Files Coverage Δ
word2number/w2n.py 97.26% <100%> (+2.13%) ⬆️
unit_testing.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33aac8a...3308f3e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in output for few cases
1 participant