Conversation
akumm2k
commented
Nov 10, 2025
- fix header height - remove unused css rules
There was a problem hiding this comment.
Pull request overview
This pull request migrates JavaScript code to TypeScript to enable more complex application logic with better type safety. The migration introduces a TypeScript build setup with ESLint, Prettier, and Vite.
Key Changes:
- Converted three JavaScript files (
age.js,invert.js,proj-highlighter.js) to TypeScript with type annotations - Added TypeScript compilation configuration with strict mode enabled
- Introduced constants modules for better code organization and type safety
- Updated HTML script tags to use ES modules from the compiled TypeScript output
Reviewed changes
Copilot reviewed 17 out of 24 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/tsconfig.json | TypeScript compiler configuration with strict mode, but contains invalid options |
| ts/src/proj_highlighter.ts | Migrated project highlighter with constants, has null checking issues |
| ts/src/invert.ts | Dark mode toggle implementation with proper null checking |
| ts/src/age.ts | Age calculation function with improved type safety |
| ts/src/constants/tools.ts | Tool constants with breaking change (c-sharp → csharp) |
| ts/src/constants/projects.ts | Project constants with inconsistent naming (camelCase vs kebab-case) |
| ts/package.json | Dependencies configuration with potentially non-existent versions |
| ts/eslint.config.mts | ESLint flat config with syntax errors |
| ts/.prettierrc | Code formatting rules (72-char line width, single quotes) |
| index.html | Updated script references to use compiled TypeScript modules |
Files not reviewed (1)
- ts/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
the blacklist option only takes directories, not file patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
References
#9