Style fixes#18
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements style and configuration improvements to the site, including correcting the author name, updating the footer, adding TypeScript build scripts, and refactoring the article layout to move author metadata. The changes enhance the build process and improve the visual presentation of article pages.
Key changes:
- Added TypeScript build scripts to both
ts/andassets/ts/package.json files for compilation - Refactored article layout to dynamically move date and author metadata under the first heading via JavaScript
- Updated TypeScript configuration to use ES2024 target and include DOM libraries
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/package.json | Added package name, marked as private, and added TypeScript build scripts |
| assets/ts/tsconfig.json | Changed target from "esnext" to "es2024", added DOM lib, removed jsx option, fixed trailing comma |
| assets/ts/package.json | Replaced placeholder test script with TypeScript build scripts |
| assets/ts/article.ts | Added DOM manipulation to reposition date and author elements after the first heading |
| assets/js/article.js.map | Updated source map reflecting the new TypeScript code |
| assets/js/article.js | Compiled JavaScript output with new DOM manipulation logic |
| assets/css/article.css | Updated word-break to overflow-wrap, modified #date and footer styles, added #author-top styles, moved scroll-progress to bottom |
| _layouts/article.html | Moved author from footer to top (correcting name from "Kumkar" to "Kumar"), changed footer message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #author { | ||
| margin: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
The '#author' selector is defined but is no longer used since the author paragraph has been removed from the footer. Consider removing this unused CSS rule.
| #author { | |
| margin: 0; | |
| } |
|
|
||
| if (container && heading && dateEl && authorEl) { | ||
| const metaWrap = document.createElement('div'); | ||
| metaWrap.className = 'post-meta'; |
There was a problem hiding this comment.
The 'post-meta' class is not defined in any CSS file in the repository. This will result in the meta wrapper div having no styling applied to it. Consider adding CSS styles for the .post-meta class or using an existing class name.
| @@ -1,6 +1,20 @@ | |||
| document.querySelectorAll('pre code').forEach((el) => { | |||
| hljs.highlightElement(el); | |||
There was a problem hiding this comment.
'hljs' is not defined.
Uh oh!
There was an error while loading. Please reload this page.