Skip to content

1.21.1 nf crawl fix#466

Open
XM666-Dev wants to merge 1 commit intoalRex-U:1.21.1-NFfrom
XM666-Dev:1.21.1-NF-CRAWL-FIX
Open

1.21.1 nf crawl fix#466
XM666-Dev wants to merge 1 commit intoalRex-U:1.21.1-NFfrom
XM666-Dev:1.21.1-NF-CRAWL-FIX

Conversation

@XM666-Dev
Copy link

Hello, I would like to ask whether it would be possible to add a transition to the Crawl animation (which relies on the vanilla swimAmount animation).

SlidingAnimator already implements a proper end transition, so it seems reasonable for Crawl to have a similar treatment.

Currently, in PlayerRenderer, the vanilla game applies a fixed positional offset when the player is swimming. This results in some visual inconsistencies, especially when transitioning in or out of the crawl state.
image
PixPin_2026-03-03_23-48-43

In this PR, the issue is addressed by interpolating the offset value instead of applying it abruptly. An additional offset is applied dynamically to smooth the swimAmount transition.

After this fix:
PixPin_2026-03-03_23-21-01

I am not entirely certain whether this adjustment belongs in this mod, but since Crawl progression consistently depends on this behavior, it seems necessary to refine it here.

@XM666-Dev XM666-Dev changed the base branch from main to 1.21.1-NF March 3, 2026 15:51
@alRex-U
Copy link
Owner

alRex-U commented Mar 9, 2026

Basically ParCool doesn't fix vanilla features so I'm wondering whether we should do this.
Is this possible to apply this change by CrawlAnimator( or only when CrawlAnimator is working)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants