Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wgpu to 0.20.0 for real #745

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Upgrade wgpu to 0.20.0 for real #745

merged 4 commits into from
Jun 10, 2024

Conversation

dfellis
Copy link
Member

@dfellis dfellis commented Jun 10, 2024

Working around a bug in copy_buffer_to_buffer by including MAP_WRITE on the "normal" buffer type

@dfellis dfellis self-assigned this Jun 10, 2024
@dfellis
Copy link
Member Author

dfellis commented Jun 10, 2024

So, this fails on the RISC-V SBC with a validation error about using MAP_WRITE with anything other than COPY_SRC, likely due to it also using the OpenGL backend and hitting a different validation path.

That means I can't merge this as-is despite the passing tests here since it doesn't really work. :/

@dfellis
Copy link
Member Author

dfellis commented Jun 10, 2024

Removed the hack mentioned at the beginning. This is the reason why this code works: gfx-rs/wgpu#5795 (comment)

@dfellis dfellis merged commit a92c75d into main Jun 10, 2024
3 checks passed
@dfellis dfellis deleted the wgpu-0.20.0-for-real branch June 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant