Use Generic type rather than object (#163)

alastairtree · Sep 1, 2021 · b6e6f74 · b6e6f74
1 parent 33d055c
commit b6e6f74
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 6 deletions.
diff --git a/LazyCache.UnitTests/CachingServiceMemoryCacheProviderTests.cs b/LazyCache.UnitTests/CachingServiceMemoryCacheProviderTests.cs
@@ -1124,6 +1124,8 @@ public void TryGetReturnsCachedValueAndTrue()
             var contains2 = sut.TryGetValue<string>("invalidkey", out var value2);
 
             Assert.IsFalse(contains2);
+
+            Assert.Throws<InvalidCastException>(() => sut.TryGetValue<int>(key, out var value3));
         }
     }
 }
diff --git a/LazyCache/CachingService.cs b/LazyCache/CachingService.cs
@@ -89,7 +89,7 @@ public virtual Task<T> GetAsync<T>(string key)
             return GetValueFromAsyncLazy<T>(item, out _);
         }
 
-        public virtual bool TryGetValue<T>(string key, out object value)
+        public virtual bool TryGetValue<T>(string key, out T value)
         {
             ValidateKey(key);
 

diff --git a/LazyCache/IAppCache.cs b/LazyCache/IAppCache.cs
@@ -15,7 +15,7 @@ public interface IAppCache
         void Add<T>(string key, T item, MemoryCacheEntryOptions policy);
         T Get<T>(string key);
         Task<T> GetAsync<T>(string key);
-        bool TryGetValue<T>(string key, out object value);
+        bool TryGetValue<T>(string key, out T value);
 
         T GetOrAdd<T>(string key, Func<ICacheEntry, T> addItemFactory);
         T GetOrAdd<T>(string key, Func<ICacheEntry, T> addItemFactory, MemoryCacheEntryOptions policy);

diff --git a/LazyCache/ICacheProvider.cs b/LazyCache/ICacheProvider.cs
@@ -12,6 +12,6 @@ public interface ICacheProvider : IDisposable
         object GetOrCreate<T>(string key, MemoryCacheEntryOptions policy, Func<ICacheEntry, T> func);
         void Remove(string key);
         Task<T> GetOrCreateAsync<T>(string key, Func<ICacheEntry, Task<T>> func);
-        bool TryGetValue(object key, out object value);
+        bool TryGetValue<T>(object key, out T value);
     }
 }
diff --git a/LazyCache/Mocks/MockCacheProvider.cs b/LazyCache/Mocks/MockCacheProvider.cs
@@ -35,7 +35,7 @@ public Task<T> GetOrCreateAsync<T>(string key, Func<ICacheEntry, Task<T>> func)
             return func(null);
         }
 
-        public bool TryGetValue(object key, out object value)
+        public bool TryGetValue<T>(object key, out T value)
         {
             throw new NotImplementedException();
         }

diff --git a/LazyCache/Mocks/MockCachingService.cs b/LazyCache/Mocks/MockCachingService.cs
@@ -52,7 +52,7 @@ public void Add<T>(string key, T item, MemoryCacheEntryOptions policy)
         {
         }
 
-        public bool TryGetValue<T>(string key, out object value)
+        public bool TryGetValue<T>(string key, out T value)
         {
             value = default(T);
             return true;

diff --git a/LazyCache/Providers/MemoryCacheProvider.cs b/LazyCache/Providers/MemoryCacheProvider.cs
@@ -78,7 +78,7 @@ public Task<T> GetOrCreateAsync<T>(string key, Func<ICacheEntry, Task<T>> factor
             return cache.GetOrCreateAsync(key, factory);
         }
 
-        public bool TryGetValue(object key, out object value)
+        public bool TryGetValue<T>(object key, out T value)
         {
             return cache.TryGetValue(key, out value);
         }