-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed spine, other improvements #37
base: master
Are you sure you want to change the base?
Conversation
* Fixed support for spine * Fixed background-size for cover (due to spine)
* Improved generated XSL-FO (speed improvement) * Removed unused imports
Thanks for your contribution! Before I start a full review, might you please explain the basic concepts of your change? Especially why you changed units in many classes from millimeters to pixels, and why the renaming of setBundlesize to addBundlesize was necessary. Thanks! |
My original intent was to fix the missing spine. I discovered that it's still possible to go your original route via After that was done I noticed a slim white bar at the top of each page. My original idea was that at some point during the conversion the float values could be an issue. It turned out it wasn't the case. Neverthenless could working with ints instead of floast provide some benifits (see Regarding the withe bar at the top: While debugging I found a workaround. If you set Hope that helps. |
Should also fix: #15
Note:
the bundlesize attribute might not be backwarts compatible!
I coun`t check that.