Merged
Conversation
howydev
requested review from
Blu-J,
Zer0dot,
adamegyed,
blakecduncan,
dancoombs,
dphilipson,
florrdv,
jakehobbs,
jaypaik,
moldy530 and
rthomare
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
howydev
force-pushed
the
howy/add-entityid-and-nonce-reader
branch
from
0b6d062 to
f3c36d4
Compare
howydev
force-pushed
the
howy/add-entityid-and-nonce-reader
branch
from
409121c to
5ceb282
Compare
Contributor
Author
|
also -> rename |
Zer0dot
reviewed
Mar 31, 2025
dphilipson
previously approved these changes
Apr 1, 2025
Contributor
dphilipson
left a comment
dphilipson
left a comment
There was a problem hiding this comment.
Looks great! Left a suggestion in the tests.
Zer0dot
reviewed
Apr 1, 2025
Zer0dot
reviewed
Apr 1, 2025
Zer0dot
reviewed
Apr 1, 2025
Zer0dot
reviewed
Apr 1, 2025
Zer0dot
approved these changes
Apr 2, 2025
howydev
force-pushed
the
howy/add-entityid-and-nonce-reader
branch
from
16fe1c4 to
d7f99b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[feat, large] added a utility to get the smallest entity id for a modular account using a utility contract. this is done via an eth_call deployment to reduce the number of round trips to obtaining both values. solidity code is here
[feat, small] added a helper function to build the full MA v2 nonce given the variables - the u152 nonceKey, the entity id, and the global validation/deferred actions flag
[chore, small] added a
saltvariable to the test file. In our current test file, it is not obvious but tests have a dependency on each other in terms of certain state. A good workaround is to set a different accountsalteach test, so we regain test independencePR-Codex overview
This PR introduces a new
entityIdAndNonceReaderwith its ABI and bytecode, enhances nonce handling inDeferralActions, and adds a method to retrieve entity IDs and nonces. It also updates tests to validate these changes.Detailed summary
entityIdAndNonceReaderAbiandentityIdAndNonceReaderBytecodeinentityIdAndNonceReader.ts.BuildNonceParamstype andbuildFullNonceKeyfunction inutils.ts.DeferralActionswithgetEntityIdAndNoncemethod.createDeferredActionTypedDataObject.client.test.tsto validate entity ID and nonce selection.