Skip to content

Commit

Permalink
Add pageKey to GetOwnersForContractResponse (#347)
Browse files Browse the repository at this point in the history
  • Loading branch information
thebrianchen authored Jul 5, 2023
1 parent a6e65d4 commit 468aae8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Added a new method `CoreNamespace.isContractAddress()` to easily check if an address is a contract or EOA. The method accepts a string address and returns a boolean value indicating if the given address is a contract address or not.

### Minor Changes
- Fixed a bug where `GetOwnersForContractResponse` was missing the `pageKey` field.

## 2.9.1

Expand Down
10 changes: 8 additions & 2 deletions src/types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,9 @@ export interface GetOwnersForContractResponse {
* Total count of unique owners. Only present if
* {@link GetOwnersForContractOptions.includeCount} is true. */
totalCount?: number;

/** Optional page key that is returned when a collection has more than 50,000 owners. */
pageKey?: string;
}

/**
Expand All @@ -868,7 +871,7 @@ export interface GetOwnersForContractWithTokenBalancesResponse {
owners: NftContractOwner[];

/** Optional page key that is returned when a collection has more than 50,000 owners. */
pageKey?: string;
pageKey: string;
}

/**
Expand Down Expand Up @@ -1616,7 +1619,10 @@ export interface GetOwnersForContractOptions {
/** Optional page key to paginate the next page for large requests. */
pageKey?: string;

/** If true, include total count of owners in the response. */
/**
* If true, include total count of owners in the response. Only applicable
* when `withTokenBalances` is not set to `true`.
*/
includeCount?: boolean;
}

Expand Down

0 comments on commit 468aae8

Please sign in to comment.