Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate **View > Scanner** top-bar menu action. #103

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

cristian64
Copy link
Collaborator

@cristian64 cristian64 commented Mar 5, 2024

This checkable menu action was removed in dd7a5ad, as it was deemed redundant after the main vertical splitter was added in 76e3b2e. However, it turned out that this convenience action was quite popular, and users have requested it back.

An effort has been made to preserve the splitter's position when the scanner's visibility is toggled.

Bonus: The action has been assigned the F3 keyboard shortcut.

Fixes #102.

Previously, a lambda was used, but extra logic is about to be added in
a follow-up commit.
Source/GUI/MainWindow.cpp Outdated Show resolved Hide resolved
This checkable menu action was removed in dd7a5ad, as it was
deemed redundant after the main vertical splitter was added in
76e3b2e. However, it turned out that this convenience action
was quite popular, and users have requested it back.

An effort has been made to preserve the splitter's position when the
scanner's visibility is toggled.

Bonus: The action has been assigned the `F3` keyboard shortcut.

Fixes aldelaro5#102.
@cristian64 cristian64 force-pushed the scanner_menu_action branch from 4de85e3 to 038eac0 Compare March 5, 2024 23:31
@dreamsyntax dreamsyntax merged commit 0d7c640 into aldelaro5:master Mar 5, 2024
2 checks passed
@dreamsyntax dreamsyntax added this to the 1.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore View > Scanner Menu Button
2 participants