Revised watch list item insertion.#139
Merged
dreamsyntax merged 4 commits intoaldelaro5:masterfrom May 16, 2024
Merged
Conversation
If multiple items are inserted, all of them are selected. The last item will become the current focus item.
The newly introduced `MemWatchModel::addNodes()` method, which efficiently inserts rows individually (as opposed to invalidating the entire layout via `layoutChanged()`), is now used. This enables `onRowsInserted()` to auto-select pasted rows. Also, note that current selection (and not the current focus index) is now used as insertion point when pasting items via `Ctrl+V`. On the other hand, the **Paste** context menu action still uses the current focus index (the index from which the context menu was deployed). The memory leak around the `copiedRootNode` variable (which was never freed before) has been addressed.
cristian64
force-pushed
the
revised_watch_list_item_insertion
branch
from
46806c0 to
e9a5b08
Compare
dreamsyntax
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129.