Treat failed save actions as cancel actions.#146
Merged
dreamsyntax merged 1 commit intoaldelaro5:masterfrom May 18, 2024
Merged
Treat failed save actions as cancel actions.#146dreamsyntax merged 1 commit intoaldelaro5:masterfrom
dreamsyntax merged 1 commit intoaldelaro5:masterfrom
Conversation
Previously, if the user exited the file browser dialog without saving the file (voluntarily, or due to I/O error), DME would still exit (or wipe out the watch model; depending on the case), causing unrecoverable data loss. Test plan: - Launch DME. - Add a few watch entries to mark the model with unsaved changes. - Clear the watch list via the **File > Clear the watch list** action. - A confirmation dialog with the **Cancel**, **No**, and **Yes** options should appear. - Click **Yes** - Once the file browser dialog opens, close it without selecting a file (or choose a filepath where the user does not have write permissions). Previous behavior: The watch list was wrongly cleared, without the user having saved it. New behavior: The user gets back to DME, as if **Cancel** had been selected in the confirmation dialog.
dreamsyntax
approved these changes
May 18, 2024
Collaborator
dreamsyntax
left a comment
dreamsyntax
left a comment
There was a problem hiding this comment.
Good catch. I'm sure I've been burned by this before without realizing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the user exited the file browser dialog without saving the file (voluntarily, or due to I/O error), DME would still exit (or wipe out the watch model; depending on the case), causing unrecoverable data loss.
Test plan:
Previous behavior: The watch list was wrongly cleared, without the user having saved it.
New behavior: The user gets back to DME, as if Cancel had been selected in the confirmation dialog.