Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Clang-Format check in GitHub Action. #168

Merged
merged 2 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ on:

jobs:
clang-format-check:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
name: Clang-Format Check
steps:
- uses: actions/checkout@v4
- uses: RafikFarhad/clang-format-github-action@v4
- uses: jidicula/clang-format-action@v4.13.0
cristian64 marked this conversation as resolved.
Show resolved Hide resolved
with:
style: "file"
sources: "Source/**/*.h,Source/**/*.cpp"
clang-format-version: '18'
check-path: Source

build-windows:
runs-on: windows-latest
Expand Down
6 changes: 3 additions & 3 deletions Source/Common/CommonUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
#elif _WIN32
#include <stdlib.h>
#elif __APPLE__
#define bswap_16(value) (static_cast<u16>((((value)&0xff) << 8) | ((value) >> 8)))
#define bswap_16(value) (static_cast<u16>((((value) & 0xff) << 8) | ((value) >> 8)))

#define bswap_32(value) \
(((uint32_t)bswap_16((uint16_t)((value)&0xffff)) << 16) | \
(((uint32_t)bswap_16((uint16_t)((value) & 0xffff)) << 16) | \
(uint32_t)bswap_16((uint16_t)((value) >> 16)))

#define bswap_64(value) \
(((uint64_t)bswap_32((uint32_t)((value)&0xffffffff)) << 32) | \
(((uint64_t)bswap_32((uint32_t)((value) & 0xffffffff)) << 32) | \
(uint64_t)bswap_32((uint32_t)((value) >> 32)))
#endif

Expand Down
3 changes: 1 addition & 2 deletions Source/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ int main(int argc, char** argv)
parser.addVersionOption();

const QCommandLineOption dolphinProcessNameOption(
QStringList() << "d"
<< "dolphin-process-name",
QStringList() << "d" << "dolphin-process-name",
QObject::tr("Specify custom name for the Dolphin Emulator process. By default, "
"platform-specific names are used (e.g. \"Dolphin.exe\" on Windows, or "
"\"dolphin-emu\" on Linux or macOS)."),
Expand Down
Loading