Add SetToDefault bool for presenting whether a flag is set to the default or not #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault or not Signed-off-by: Sergen Yalçın <[email protected]>
|
I appreciate the contribution, but I'd prefer a more general approach of being able to determine the "source" of the value. For example, if coming from an environment variable, default, configuration file, and so on. |
Makes sense. I would be happy to implement this. Let me update the PR. |
|
Any luck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #365
This PR adds a new API field:
SetToDefault. This new field will present whether a flag is set to the default or not.