avoid returning errors when one-or-more groups have no matches #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue using participle when using a structure like the following
The code works as intended, but when you use a
@String+
as a part of your union types your error messages get a lot less helpful. Instead of getting errors likemost of your errors turn into
This ends up this way because the group node returns an error when
@Foo+
doesn't match the minimum quantity which then overrides any other useful error reporting and failthroughsThis small change makes it so that the error is only reported if there is at least one match in a group (and adds a test to enforce it)