Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
setupViews
ondraw:rect
, calling it inlayoutSubviews:
where the new frame is already set, soscale
can be recalculated with the new width.The only problem I see (specially when enabling Slow animations on the simulator) is that
setupViews
ends before the rotation animation starts, so you can see the labels with the new sizes before the views rotate. I tried wrappingsetupViews
inside an animation block without effect.draw:rect
will be called by UIKit on rotation when settingview.contentMode = UIViewContentModeRedraw
(default value isscaleToFill
), but I've read that implementingdraw:rect
reduces performance because a graphic context is created to be used in the method.